Use CR adjoint for logdet(::Cholesky)#1226
Merged
CarloLucibello merged 4 commits intoFluxML:masterfrom Jun 20, 2022
Merged
Conversation
Member
Author
|
The CR PR was merged, so this PR is ready. |
CarloLucibello
approved these changes
Jun 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once JuliaDiff/ChainRules.jl#613 is merged, the Zygote adjoint for
logdet(::Cholesky)can be removed. (FYI the CR PR also adds a rule fordet(::Cholesky)and hence fixes some existing issues since no such rule exists in Zygote.)Unfortunately, using this CR rule requires updating the Julia compat entry from 1.3 to 1.6. According to the RegistryCI docs a patch release may not narrow the compat range for Julia. Hence you might want to postpone this PR until the next breaking release of Zygote.