Add service newsblur - #183
Open
Simx72 wants to merge 20 commits into
Open
Conversation
Creating a basic ServiceHooks object for the NewsBlur API
remove console.log
half implementation of missing hooks
Update last changes from Fluentflame
Author
|
Oh, and I was signing with the wrong key. My bad |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, this is my pull request to add the service Newsblur to the Fluentflame project.
I have added the files
newsblur.tsandtest_newsblur.ts.For the implementation, I have copied other implementations from the folder
services/and adapted them to Newsblur.For the development, I used:
pnpmas package managerThere is some stuff that I still don't understand about Redux and Fluentflame Reader, like when to use dispatch and what should it return, or where are RSSSources and RSSItem stored.
However, I am pretty shure that the
authenticate(),updateSources(),syncItems()andmarkAllRead()are implemented correctly.I stay available for changes, concerns, etc. I'd really like to learn how it's implemented in its entirety.