Fresh up and workaround for node variant state issue#34
Open
sbruggmann wants to merge 2 commits intoFlowpack:mainfrom
Open
Fresh up and workaround for node variant state issue#34sbruggmann wants to merge 2 commits intoFlowpack:mainfrom
sbruggmann wants to merge 2 commits intoFlowpack:mainfrom
Conversation
… nasty bug which did not update the selectbox while translating nodes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NodeVariantSelector did not correctly update if you added a new translation for an existing shine-through node. It still displayed the info, that this node is still the shine-through node.
This PR does introduce a workaround to show the correct state: The node is translated, successfully stored, but was not yet updated in the UI.
And: