Skip to content

Revert 1 codex/fix pagination param validation#6479

Open
sairamveereddy wants to merge 3 commits into
FlowiseAI:mainfrom
sairamveereddy:revert-1-codex/fix-pagination-param-validation
Open

Revert 1 codex/fix pagination param validation#6479
sairamveereddy wants to merge 3 commits into
FlowiseAI:mainfrom
sairamveereddy:revert-1-codex/fix-pagination-param-validation

Conversation

@sairamveereddy
Copy link
Copy Markdown

What changed

  • Added strict validation for shared page and limit query parsing.
  • Rejects non-numeric, decimal, negative, and repeated query values before they can flow into pagination logic.
  • Added focused Jest coverage for valid, default, zero, and invalid pagination inputs.

Why

getPageAndLimitParams previously used parseInt and only checked for negative numbers. Values like abc, 1.5, or repeated query params could become NaN or be partially parsed, then leak into controller/service pagination behavior.

Validation

  • Reviewed the diff.
  • Ran git diff --cached --check successfully.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants