Validate filepaths in file utilities

[christopherholland-workday]

1. Validate that chatflowId is a valid UUID's
2. Validate that chatId is present
3. Ensure that the filename does not contain path traversal patterns
4. Ensure that the sanitized filename does not contain path traversal patterns

Addresses CodeQL findings 45-50

(Moved from #5778 because the previous PR got polluted)

[gemini-code-assist]

Summary of Changes

Hello @christopherholland-workday, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the security of file utility functions by introducing comprehensive input validation. It focuses on preventing path traversal attacks by ensuring that identifiers like chatId and chatflowId conform to UUID standards and that all filenames, both before and after sanitization, are free from unsafe path characters. These changes directly mitigate identified security vulnerabilities.

Highlights

• Input Validation for File Utilities: Implemented robust validation for chatId and chatflowId to ensure they are valid UUIDs, preventing malformed identifiers from being processed.
• Path Traversal Prevention: Introduced checks to prevent path traversal vulnerabilities by validating filename and sanitizedFilename for unsafe characters and patterns.
• Security Enhancements: Integrated the isUnsafeFilePath utility to provide comprehensive security checks against malicious file paths, directly addressing CodeQL findings.

Changelog

• packages/components/src/storageUtils.ts
  • Imported isUnsafeFilePath for enhanced path validation.
  • Added validation to ensure chatId is present before processing.
  • Implemented isUnsafeFilePath check for the fileName parameter.
  • Added a post-sanitization check to ensure sanitizedFilename does not contain path separators.
• packages/server/src/controllers/get-upload-file/index.ts
  • Imported isUnsafeFilePath and isValidUUID for use in the controller.
  • Added early return validation for chatflowId to ensure it is a valid UUID.
  • Added early return validation to confirm chatId is provided.
  • Integrated isUnsafeFilePath check for the fileName parameter to prevent path traversal.

Activity

• No specific activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enhances security by adding validation for file paths used in file utilities. The changes correctly validate chatflowId and fileName to prevent path traversal attacks. However, the validation for chatId is incomplete; it is checked for existence but not for the UUID format as stated in the pull request description. I've added comments to point out where this validation should be added for comprehensive security.