Enable "Touch-and-Hold" Gesture as Right-Click Equivalent on Mobile Devices#167
Enable "Touch-and-Hold" Gesture as Right-Click Equivalent on Mobile Devices#167javier-godoy merged 2 commits intomasterfrom
Conversation
This version adds support to enable "Touch-and-Hold" Gesture as Right-Click Equivalent on Mobile Devices. Close #149
WalkthroughModule version updated in pom.xml to 2.4.0-SNAPSHOT. NpmPackage annotation for @flowingcode/google-map bumped from 3.8.2 to 3.9.0 across GoogleMap, GoogleMapMarker, GoogleMapPoint, and GoogleMapPoly classes. No other code or dependency declarations changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pom.xml (1)
7-7: Version bump looks good.No issues spotted with moving to 2.4.0-SNAPSHOT.
When releasing, remember to update the Directory entry and tag accordingly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
pom.xml(1 hunks)src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMap.java(1 hunks)src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapMarker.java(1 hunks)src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoint.java(1 hunks)src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoly.java(1 hunks)
🔇 Additional comments (4)
src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoint.java (1)
31-31: NPM package bump to 3.9.0 is OK.No further changes required here.
src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapMarker.java (1)
42-42: NPM package bump to 3.9.0 is OK.This aligns with the PR goal; event wiring remains compatible.
src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoly.java (1)
42-42: NPM package bump to 3.9.0 is OK.No concerns.
src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMap.java (1)
53-53: Verify long‑press → right‑click works end‑to‑end with v3.9.0.
- Wrappers declare @flowingcode/google-map v3.9.0: src/main/java/com/flowingcode/vaadin/addons/googlemaps/{GoogleMap.java, GoogleMapMarker.java, GoogleMapPoint.java, GoogleMapPoly.java}. Marker/map right‑click wiring present: @DomEvent("google-map-marker-rightclick") and addEventListener("google-map-rightclick").
- No public 3.9.0 release or changelog found for the web component; confirm v3.9.0 is published and that the component emits google-map-rightclick / google-map-marker-rightclick on touch‑and‑hold (mobile).
Optional: expose configurable long‑press duration on the server API.



Close #149.
This PR updates web-component version to 3.9.0, this version adds support for right-click on mobile devices.
Component version was updated accordingly.
Summary by CodeRabbit
Chores
Bug Fixes
Refactor