[7849] Carried-over search term from Home status tiles breaks pagination on Hosted Instances list #7925
[7849] Carried-over search term from Home status tiles breaks pagination on Hosted Instances list #7925n-lark wants to merge 10 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7925 +/- ##
==========================================
- Coverage 75.72% 75.64% -0.09%
==========================================
Files 434 434
Lines 23198 23254 +56
Branches 6161 6182 +21
==========================================
+ Hits 17567 17590 +23
- Misses 5631 5664 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| return { | ||
| loading: false, | ||
| loading: true, | ||
| fetchSeq: 0, |
There was a problem hiding this comment.
this looks like we're patching up some strong code smells
There was a problem hiding this comment.
an abortController would be the better approach here
There was a problem hiding this comment.
by using the fetchSeq leaves the requests to get fulfilled even if they should have been canceled
There was a problem hiding this comment.
swapped to abortController
| @update:page-size="onPageSizeChange" | ||
| > | ||
| <template #actions> | ||
| <ff-popover |
There was a problem hiding this comment.
there's an outline on the button when first getting clicked which we should remove
There was a problem hiding this comment.
This is the keyboard-focus outline, it's on every ff-btn app-wide, not unique to this PR. It has to stay for keyboard focus (WCAG 2.4.7) but we can probably hide it just on mouse-click. It would be a shared button change so if we want that we should create a follow up since it has a wide scope.
| v-for="filter in statusFilters" :key="filter.key" | ||
| :title="filter.label" | ||
| :data-action="'filter-' + filter.key" | ||
| @click="toggleStatusGroup(filter.key)" |
There was a problem hiding this comment.
we should keep the url params in sync with the stats group when toggled. Ex: landing on the instances page with a filter from the dashboard, changing the filter works but upon page refresh were taken back to the original filter we landed with
2 participants
Description
See test plan here: #7849 (comment)
What changed & why
searchQuery, so the page now reads that param and drives the server query — clicking an instance in global search lands on the list filtered by that name.Related Issue(s)
Resolves #7849
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel