Open
Conversation
- Add persistentHighlight option: when true, highlighted nodes and tabs stay highlighted until the next highlight() or clearHighlight() call instead of auto-clearing after 10 seconds - Extract clearHighlight() as a standalone function and expose it on the comparison result object for external control - Apply glow to <rect> child for group nodes so label text stays readable - Fix getItemDifferences to iterate the union of both objects' keys, not just value1 — properties only in the new version were invisible - Fix array comparison to use max length of both arrays - Add allChanges option: when true, position-changed nodes also get their full property diff instead of being short-circuited Closes #91, closes #92, closes #93
andypalmi
force-pushed
the
fix/compare-highlight-and-diff
branch
from
c4d14d8 to
0528bac
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
persistentHighlightoption: highlighted nodes/tabs stay highlighted until the nexthighlight()orclearHighlight()call instead of auto-clearing after 10sclearHighlight()as a standalone function and expose it on the comparison result object<rect>child for group nodes so label text stays readablegetItemDifferencesto iterate the union of both objects' keys — properties only in the new version were invisibleallChangesoption: position-changed nodes also get their full property diffCloses #91, closes #92, closes #93
Test plan
persistentHighlight: true— verify highlights persist until next navigationclearHighlight()— verify all highlights are removed