Fix cross-tab project integrity and autosave ordering#343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #337
Closes #338
Closes #339
Closes #340
Closes #341
Closes #342
This project-integrity wave removes the remaining ways one drawing could mutate, save, or export another open tab.
Root causes
Several commands still held raw canvas references or singleton stores from the original one-project editor. Autosave also allowed serialize/thumbnail/repository work to overlap and read the project id after asynchronous work. With multiple tabs, those assumptions allowed shared blank canvases, default stores, and stale save completions to cross project boundaries.
Verification
npm test -- --run— 98 files, 562 tests passednpm run build— TypeScript, Vite, and PWA build passednpm run lint— 0 errors; 5 existingno-explicit-anywarningsgit diff --check