Skip to content

Handle stringified binary predict_proba labels#2675

Open
FlorianPfaff wants to merge 2 commits into
mainfrom
fix-predict-proba-string-label-order
Open

Handle stringified binary predict_proba labels#2675
FlorianPfaff wants to merge 2 commits into
mainfrom
fix-predict-proba-string-label-order

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • Detect stringified binary positive labels such as "1" and "true" when selecting the positive column from two-column predict_proba output.
  • Keep the existing fallback behavior for nonnumeric/non-binary class labels.
  • Add a regression test for reversed stringified binary class order (classes_ = ["1", "0"]).

Bug fixed

Before this change, CalibratedPairwiseAssociationModel respected classes_ = [1, 0] but defaulted to column 1 for classes_ = ["1", "0"], thereby returning the negative-class probability as the match probability.

Validation

  • Locally syntax-checked the modified source file and new test file.
  • Could not run the full repository test suite in the sandbox because direct GitHub cloning is unavailable there.

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 49.46s
✅ JSON prettier 7 0 0 0 0.91s
✅ JSON v8r 7 0 0 7.58s
✅ MARKDOWN markdownlint 68 0 0 0 1.77s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.43s
✅ PYTHON black 872 1 0 0 39.3s
✅ PYTHON isort 872 3 0 0 4.88s
✅ REPOSITORY checkov yes no no 43.44s
✅ REPOSITORY gitleaks yes no no 8.79s
✅ REPOSITORY git_diff yes no no 0.12s
✅ REPOSITORY secretlint yes no no 27.67s
✅ REPOSITORY syft yes no no 3.99s
✅ REPOSITORY trivy-sbom yes no no 8.86s
✅ REPOSITORY trufflehog yes no no 16.03s
✅ YAML prettier 11 0 0 0 0.73s
✅ YAML v8r 11 0 0 10.48s
✅ YAML yamllint 11 0 0 0.44s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant