Skip to content

Handle nonnumeric predict_proba class labels#2674

Merged
FlorianPfaff merged 2 commits into
mainfrom
fix/predict-proba-nonnumeric-classes
Jun 13, 2026
Merged

Handle nonnumeric predict_proba class labels#2674
FlorianPfaff merged 2 commits into
mainfrom
fix/predict-proba-nonnumeric-classes

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • Avoid converting model.classes_ through the active PyRecEst numeric backend when selecting the positive predict_proba column.
  • Preserve the numeric positive-label behavior for classes_ = [1, 0].
  • Fall back to column 1 for nonnumeric class labels instead of risking backend conversion errors.

Testing

  • Not run locally: the execution container cannot resolve github.com, so I used the GitHub connector for repository writes.
  • Added a regression test for nonnumeric classes_ fallback in tests/test_association_models.py.

@FlorianPfaff FlorianPfaff merged commit 872f7ab into main Jun 13, 2026
16 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant