Skip to content

Fix PyTorch Sylvester semidefinite denominator#2670

Merged
FlorianPfaff merged 2 commits into
mainfrom
fix/pytorch-sylvester-semidefinite-denominator
Jun 13, 2026
Merged

Fix PyTorch Sylvester semidefinite denominator#2670
FlorianPfaff merged 2 commits into
mainfrom
fix/pytorch-sylvester-semidefinite-denominator

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • Fix the PyTorch solve_sylvester real symmetric semidefinite shortcut so it only masks genuinely zero denominators instead of adding an identity matrix to every diagonal denominator.
  • Add a regression test showing that near-skew right-hand sides accepted by the shortcut still satisfy the Sylvester residual tightly in non-null eigenspaces.

Testing

  • Not run locally: the execution container cannot resolve github.com, so I used the GitHub connector for repository writes.
  • Added tests/backend_support/test_pytorch_sylvester_semidefinite_shortcut.py, which runs the regression under PYRECEST_BACKEND=pytorch via the existing backend runner.

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) June 13, 2026 15:22
@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 48.47s
✅ JSON prettier 7 0 0 0 0.85s
✅ JSON v8r 7 0 0 7.06s
✅ MARKDOWN markdownlint 68 0 0 0 1.6s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.59s
✅ PYTHON black 870 0 0 0 41.37s
✅ PYTHON isort 870 0 0 0 6.81s
✅ REPOSITORY checkov yes no no 44.48s
✅ REPOSITORY gitleaks yes no no 9.14s
✅ REPOSITORY git_diff yes no no 0.12s
✅ REPOSITORY secretlint yes no no 26.7s
✅ REPOSITORY syft yes no no 4.61s
✅ REPOSITORY trivy-sbom yes no no 8.31s
✅ REPOSITORY trufflehog yes no no 16.39s
✅ YAML prettier 11 0 0 0 0.66s
✅ YAML v8r 11 0 0 10.52s
✅ YAML yamllint 11 0 0 0.46s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff merged commit 4e3742b into main Jun 13, 2026
19 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant