Feature/marker click event by jseremba · Pull Request #13 · FlockOfBirds/google-maps

jseremba · 2018-05-07T07:05:59Z

Add marker click events
Update webmodeler visibility props
Update widget icon

akileng56 · 2018-05-16T08:37:32Z

            <caption>API key</caption>
            <category>General</category>
-            <description>The Google Maps Javascript API v3 does not require an API key to function correctly. However, Google strongly encourages you to load the Maps API using an APIs key</description>
+            <description>The Google Maps Javascript API v3 requires an API key.</description>


Remove the full stop

This is the DEPRECATED older version of Google Maps

akileng56 · 2018-05-16T08:38:40Z

+        <property key="onClickMicroflow" type="microflow" required="false" entityProperty="locationsEntity">
+            <caption>On click microflow</caption>
+            <category>Markers</category>
+            <description>The microflow that will be executed when a marker is click </description>


'click' should be 'clicked'

akileng56 · 2018-05-16T08:38:50Z

+        <property key="onClickNanoflow" type="nanoflow" required="false" entityProperty="locationsEntity">
+            <caption>On click nanoflow</caption>
+            <category>Markers</category>
+            <description>The nanoflow that will be executed when a marker is click </description>


akileng56 · 2018-05-16T08:39:07Z

+        <property key="page" type="form" required="false">
+            <caption>Page</caption>
+            <category>Markers</category>
+            <description>The page that will be opened when a marker is click</description>


akileng56 · 2018-05-16T08:44:58Z

+        return errorMessage;
+    }
+
+    private executeOnClickAction = (data: LatLng) => {


What does this function do creates an object 'and' also executes an action, Function should do one thing. separate this => createOnclickObject , executeOnClick

akileng56 · 2018-05-16T08:48:09Z

        _args?: {
-            location?: "content" | "popup" | "modal",
-            domNode?: HTMLElement,
+            location?: "content" | "popup" | "modal" | "node",


Is node used anywhere or just in code

I added node because the mendix client typings API openForm was updated and argument location changed to "content" | "popup" | "modal" | "node"

akileng56 · 2018-05-16T08:50:13Z

+                        error: error => window.mx.ui.error(`Error while executing the on change nanoflow: ${error.message}`)
+                    });
+                } else if (onClickEvent === "showPage" && page) {
+                    context.setContext(object.getEntity(), object.getGuid());


Move this to the line after creating the context or in the new function after separating
const context = new mendix.lib.MxContext();
context.setContext(object.getEntity(), object.getGuid());

akileng56 · 2018-05-16T08:53:10Z

+    public static validateProps(props: GoogleMapContainerProps): string {
+        let errorMessage = "";
+        if (props.onClickEvent === "callMicroflow" && !props.onClickMicroflow) {
+            errorMessage = "A 'Microflow' is required for 'Markers' 'Call a microflow'";


A 'Microflow' is required for on click 'Marker' event 'Call a Microflow'

akileng56 · 2018-05-16T08:53:42Z

+        } else if (props.onClickEvent === "callNanoflow" && !props.onClickNanoflow.nanoflow) {
+            errorMessage = "A 'Nanoflow' is required for 'Markers' 'Call a nanoflow'";
+        } else if (props.onClickEvent === "showPage" && !props.page) {
+            errorMessage = "A 'Page' is required for 'Markers' 'Show a page'";


akileng56 · 2018-05-16T08:54:10Z

+        if (props.onClickEvent === "callMicroflow" && !props.onClickMicroflow) {
+            errorMessage = "A 'Microflow' is required for 'Markers' 'Call a microflow'";
+        } else if (props.onClickEvent === "callNanoflow" && !props.onClickNanoflow.nanoflow) {
+            errorMessage = "A 'Nanoflow' is required for 'Markers' 'Call a nanoflow'";


codecov-io · 2018-05-17T07:09:39Z

Codecov Report

Merging #13 into master will decrease coverage by 0.9%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage    82.5%   81.59%   -0.91%     
==========================================
  Files           3        3              
  Lines         160      163       +3     
  Branches       42       43       +1     
==========================================
+ Hits          132      133       +1     
- Misses         28       30       +2

Impacted Files	Coverage Δ
src/components/Marker.ts	`100% <ø> (ø)`	⬆️
src/components/Map.ts	`79.59% <66.66%> (-0.97%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b485fb2...2ee9c24. Read the comment docs.

djkwagala

When onClick === "DoNothing" atleast we should have a onhover to show the coordinates. (this is the same case with charts.
This option can be disabled via xml-configs
This is to deal with situations where the google-maps interpreted the location via its "Address" and the coordinates were missing or "0,0".

jseremba and others added 5 commits May 2, 2018 14:12

Add marker click events

65f3cab

Update widget icon

c2126b1

Update webmodeler visibility props

bb16cf6

Add marker onclick nanoflow

0cd1f98

Make API key required

4562eb1

akileng56 suggested changes May 16, 2018

View reviewed changes

jseremba force-pushed the feature/marker-click-event branch from 1d11feb to 522d43e Compare May 17, 2018 07:09

Add marker onclick form location

e1518d9

jseremba force-pushed the feature/marker-click-event branch from 522d43e to e1518d9 Compare May 17, 2018 07:45

jseremba added 2 commits May 21, 2018 13:15

Bump up version to 1.6.0

fb26a95

Update read me, webmodeler page location

179806e

jseremba force-pushed the feature/marker-click-event branch from 3416a75 to 179806e Compare May 23, 2018 11:20

jseremba added 2 commits May 28, 2018 09:49

Update icon

ca0da3d

Review feedback: update marker location

df6bb40

djkwagala suggested changes May 28, 2018

View reviewed changes

Remove validations for no static location

d491621

jseremba force-pushed the feature/marker-click-event branch 3 times, most recently from 8ebc13a to f1f3dab Compare June 8, 2018 13:56

Clean up code

2ee9c24

jseremba force-pushed the feature/marker-click-event branch from f1f3dab to 2ee9c24 Compare June 8, 2018 14:06

Conversation

jseremba commented May 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jseremba May 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov-io commented May 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

djkwagala left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jseremba commented May 7, 2018 •

edited

Loading

jseremba May 16, 2018 •

edited

Loading

codecov-io commented May 17, 2018 •

edited

Loading