Skip to content

Fix(core-ruffle): resolve standalone Ruffle path inside .app bundle on macOS #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mark-henry wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix(core-ruffle): resolve standalone Ruffle path inside .app bundle on macOS #516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion extensions/core-ruffle/src/middleware/standalone.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,11 @@ export class RuffleStandaloneMiddleware implements IGameMiddleware {
};

// Replace application path with ruffle standalone executable (<base>/<version>/<executable>)
// On macOS the release ships as a `Ruffle.app` bundle, so the binary lives inside it.
const executable = os.platform() === 'win32' ? 'ruffle.exe' : 'ruffle';
const execPath = path.join(this.ruffleStandaloneRoot, middlewareConfig.version, executable);
const execPath = os.platform() === 'darwin'
? path.join(this.ruffleStandaloneRoot, middlewareConfig.version, 'Ruffle.app', 'Contents', 'MacOS', 'ruffle')
: path.join(this.ruffleStandaloneRoot, middlewareConfig.version, executable);

// If exec path is missing, we need to download the correct version
if (!fs.existsSync(execPath)) {
Expand Down