fix(rocm): make TVM-FFI index and store JIT kernels portable to HIP - #133
Draft
zihaomu wants to merge 9 commits into
Draft
fix(rocm): make TVM-FFI index and store JIT kernels portable to HIP#133zihaomu wants to merge 9 commits into
zihaomu wants to merge 9 commits into
Conversation
- Add hip_compat.h shim mapping CUDA runtime API to HIP equivalents - Update pinned_tensor.cpp to compile under both nvcc and hipcc - Add ROCm detection in arch.py (is_rocm, get_rocm_gfx_arch, is_gfx11xx_family) - Guard NVIDIA arch checks to return None on ROCm - Skip nvcc version check in _toolchain.py when on ROCm - Add ROCm build path in setup.py (ROCM_HOME, amdhip64, --offload-arch) - Add _hip_cflags() in kernel/utils.py for JIT compilation on ROCm - Add is_rocm() and driver_hip_version() in backend.py - Add rocm-smi fallback in __main__.py for clangd generation - Add TODO(ROCm) for NCCL->RCCL, flashinfer/sgl_kernel ROCm builds, Triton autotune RDNA3 tuning, PDL equivalent, hiprtc JIT cache - Add AMD ROCm classifier in pyproject.toml
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kDLROCMtensors in the generic index and store TVM-FFI kernels;Incremental review scope
Relative to
zihaomu:feat/rocm-rdna3-rdna4-foundation:python/freetoken/kernel/csrc/include/freetoken/utils.cuhpython/freetoken/kernel/csrc/jit/index.cupython/freetoken/kernel/csrc/jit/store.cutests/kernels/test_jit_index_store.pyDiff size: 54 additions, 8 deletions.
Dependency
Validation
gfx1201)2.11.0+rocm7.14.0, HIP7.14.6085054 passedCompatibility
CUDA branches remain behind the non-ROCm preprocessor path. Physical NVIDIA regression testing is not claimed; this PR remains Draft until #132 and CUDA CI establish the final base.