Skip to content

fix(tokens): text on surfaces fails WCAG AA contrast #8236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zaimwa9 merged 2 commits into from
Aug 11, 2026
+15 −12
Merged

fix(tokens): text on surfaces fails WCAG AA contrast #8236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
232c028
fix(ds): make status text readable on its own surface
talissoncosta Aug 6, 2026
e3e858c
docs(ds): scope the token descriptions to light mode
talissoncosta Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions frontend/common/theme/tokens.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,9 @@
"tertiary": { "cssVar": "--color-text-tertiary", "light": "#9da4ae", "dark": "rgba(255, 255, 255, 0.48)" },
"disabled": { "cssVar": "--color-text-disabled", "light": "#9da4ae", "dark": "rgba(255, 255, 255, 0.32)" },
"action": { "cssVar": "--color-text-action", "light": "#6837fc", "dark": "#906af6" },
"danger": { "cssVar": "--color-text-danger", "light": "#ef4d56", "dark": "#ef4d56" },
"success": { "cssVar": "--color-text-success", "light": "#27ab95", "dark": "#27ab95" },
"warning": { "cssVar": "--color-text-warning", "light": "#ff9f43", "dark": "#ff9f43" },
"danger": { "cssVar": "--color-text-danger", "light": "#bb1720", "dark": "#ef4d56", "description": "In light mode, darker than border/icon danger to clear 4.5:1 on the tint." },
"success": { "cssVar": "--color-text-success", "light": "#13787b", "dark": "#27ab95", "description": "In light mode, darker than border/icon success to clear 4.5:1 on the tint." },
"warning": { "cssVar": "--color-text-warning", "light": "#9f5208", "dark": "#ff9f43", "description": "In light mode, darker than border/icon warning to clear 4.5:1 on the tint." },
"info": { "cssVar": "--color-text-info", "light": "#0aaddf", "dark": "#0aaddf" }
},
"code": {
Expand Down
6 changes: 3 additions & 3 deletions frontend/common/theme/tokens.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,14 +198,14 @@ export const colorSurfaceWarning =

// Text
export const colorTextAction = 'var(--color-text-action, #6837fc)'
export const colorTextDanger = 'var(--color-text-danger, #ef4d56)'
export const colorTextDanger = 'var(--color-text-danger, #bb1720)'
export const colorTextDefault = 'var(--color-text-default, #1a2634)'
export const colorTextDisabled = 'var(--color-text-disabled, #9da4ae)'
export const colorTextInfo = 'var(--color-text-info, #0aaddf)'
export const colorTextSecondary = 'var(--color-text-secondary, #656d7b)'
export const colorTextSuccess = 'var(--color-text-success, #27ab95)'
export const colorTextSuccess = 'var(--color-text-success, #13787b)'
export const colorTextTertiary = 'var(--color-text-tertiary, #9da4ae)'
export const colorTextWarning = 'var(--color-text-warning, #ff9f43)'
export const colorTextWarning = 'var(--color-text-warning, #9f5208)'

// Chart
export const colorChart1 = 'var(--color-chart-1, #0aaddf)'
Expand Down
6 changes: 3 additions & 3 deletions frontend/documentation/TokenReference.generated.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,23 +205,23 @@ export const AllTokens: StoryObj = {
<code>--color-text-danger</code>
</td>
<td>
<code>var(--red-500)</code>
<code>var(--red-700)</code>
</td>
</tr>
<tr>
<td>
<code>--color-text-success</code>
</td>
<td>
<code>var(--green-500)</code>
<code>var(--green-600)</code>
</td>
</tr>
<tr>
<td>
<code>--color-text-warning</code>
</td>
<td>
<code>var(--orange-500)</code>
<code>var(--orange-800)</code>
</td>
</tr>
<tr>
Expand Down
9 changes: 6 additions & 3 deletions frontend/web/styles/_tokens.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,14 +105,14 @@

// Text
--color-text-action: var(--purple-600);
--color-text-danger: var(--red-500);
--color-text-danger: var(--red-700);
--color-text-default: var(--slate-600);
--color-text-disabled: var(--slate-300);
--color-text-info: var(--blue-500);
--color-text-secondary: var(--slate-500);
--color-text-success: var(--green-500);
--color-text-success: var(--green-600);
--color-text-tertiary: var(--slate-300);
--color-text-warning: var(--orange-500);
--color-text-warning: var(--orange-800);

// Code
--color-code-builtin: var(--gold-700);
Expand Down Expand Up @@ -208,10 +208,13 @@
--color-surface-success: oklch(from var(--green-500) 0.18 0.02 h);
--color-surface-warning: oklch(from var(--orange-500) 0.18 0.02 h);
--color-text-action: var(--purple-400);
--color-text-danger: var(--red-500);
--color-text-default: var(--slate-0);
--color-text-disabled: oklch(from var(--slate-0) l c h / 0.32);
--color-text-secondary: var(--slate-300);
--color-text-success: var(--green-500);
--color-text-tertiary: oklch(from var(--slate-0) l c h / 0.48);
--color-text-warning: var(--orange-500);
--color-code-builtin: var(--gold-400);
--color-code-comment: var(--slate-500);
--color-code-keyword: var(--purple-400);
Expand Down
Loading