Skip to content

feat(experimentation): support multi-status filter in frontend #7894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zaimwa9 wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −5
Open

feat(experimentation): support multi-status filter in frontend #7894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/common/types/requests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1033,7 +1033,7 @@ export type Req = {
}
getExperiments: PagedRequest<{
environmentId: string
status?: ExperimentStatus
status?: ExperimentStatus | ExperimentStatus[]
}>
createExperiment: {
environmentId: string
Expand Down
18 changes: 14 additions & 4 deletions frontend/common/utils/base/_utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,9 +504,10 @@ emailRegex: /(?:[a-z0-9!#$%&'*+/=?^_`{|}~-]+(?:\.[a-z0-9!#$%&'*+/=?^_`{|}~-]+)*|
const target = e.target

if (target.getAttribute) {
return target.type === 'checkbox' || target.type === 'radio'
? target.getAttribute('checked')
: typeof target.value === 'string'
if (target.type === 'checkbox' || target.type === 'radio') {
return target.getAttribute('checked')
}
return typeof target.value === 'string'
? target.value
: target.getAttribute('data-value') || target.getAttribute('value')
}
Expand All @@ -519,9 +520,18 @@ emailRegex: /(?:[a-z0-9!#$%&'*+/=?^_`{|}~-]+(?:\.[a-z0-9!#$%&'*+/=?^_`{|}~-]+)*|

toParam(obj) {
// {min:100,max:200} -> min=100&max=200
// {status:['running','paused']} -> status=running&status=paused
return Object.keys(obj)
.filter((v) => obj[v] !== undefined)
.map((k) => `${encodeURIComponent(k)}=${encodeURIComponent(obj[k])}`)
.flatMap((k) => {
const val = obj[k]
if (Array.isArray(val)) {
return val.map(
(v) => `${encodeURIComponent(k)}=${encodeURIComponent(v)}`,
)
}
return `${encodeURIComponent(k)}=${encodeURIComponent(val)}`
})
.join('&')
},

Expand Down
Loading