Skip to content

feat(experimentation): support multi-status filter on experiments list#7893

Open
Zaimwa9 wants to merge 1 commit into
mainfrom
feat/experiment-multi-status-filter
Open

feat(experimentation): support multi-status filter on experiments list#7893
Zaimwa9 wants to merge 1 commit into
mainfrom
feat/experiment-multi-status-filter

Conversation

@Zaimwa9

@Zaimwa9 Zaimwa9 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Changes

Contributes to experimentation feature

The experiments list endpoint now accepts multiple status values as repeated query params (?status=running&status=paused). Previously only a single status string was accepted.

  • get_queryset uses getlist("status") and filter(status__in=...) — fully backwards compatible with single-value usage
  • Validation reports all invalid values at once

How did you test this code?

  • Existing parametrised single-status filter tests pass unchanged (backwards compatible)
  • Added test_get_list__filter_by_multiple_statuses__returns_matching
  • Added test_get_list__mixed_valid_and_invalid_status__returns_400
  • Backend mypy passes

Accept multiple status values as repeated query params
(?status=running&status=paused) for the experiments list endpoint.
@vercel

vercel Bot commented Jun 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Jun 26, 2026 1:30pm
flagsmith-frontend-preview Ignored Ignored Jun 26, 2026 1:30pm
flagsmith-frontend-staging Ignored Ignored Jun 26, 2026 1:30pm

Request Review

@github-actions github-actions Bot added api Issue related to the REST API feature New feature or request labels Jun 26, 2026
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.62%. Comparing base (1ce5f34) to head (8427186).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7893   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files        1487     1487           
  Lines       58475    58502   +27     
=======================================
+ Hits        57669    57696   +27     
  Misses        806      806           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Zaimwa9 Zaimwa9 requested a review from gagantrivedi June 26, 2026 14:07
@Zaimwa9 Zaimwa9 marked this pull request as ready for review June 26, 2026 14:07
@Zaimwa9 Zaimwa9 requested a review from a team as a code owner June 26, 2026 14:07
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-7893 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-7893 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-7893 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-7893 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7893 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7893 Finished ✅ Results

@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Jun 26, 2026
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  41.8 seconds
commit  8427186
info  🔄 Run: #17878 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  45.4 seconds
commit  8427186
info  🔄 Run: #17878 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  1 minute, 9 seconds
commit  8427186
info  🔄 Run: #17878 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 1 second
commit  8427186
info  🔄 Run: #17878 (attempt 1)

@github-actions

Copy link
Copy Markdown
Contributor

Visual Regression

17 screenshots compared. See report for details.
View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants