feat(experimentation): support multi-status filter on experiments list#7893
Open
Zaimwa9 wants to merge 1 commit into
Open
feat(experimentation): support multi-status filter on experiments list#7893Zaimwa9 wants to merge 1 commit into
Zaimwa9 wants to merge 1 commit into
Conversation
Accept multiple status values as repeated query params (?status=running&status=paused) for the experiments list endpoint.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7893 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 1487 1487
Lines 58475 58502 +27
=======================================
+ Hits 57669 57696 +27
Misses 806 806 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Docker builds report
|
Contributor
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
|
Contributor
Visual Regression17 screenshots compared. See report for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Contributes to experimentation feature
The experiments list endpoint now accepts multiple
statusvalues as repeated query params (?status=running&status=paused). Previously only a single status string was accepted.get_querysetusesgetlist("status")andfilter(status__in=...)— fully backwards compatible with single-value usageHow did you test this code?
test_get_list__filter_by_multiple_statuses__returns_matchingtest_get_list__mixed_valid_and_invalid_status__returns_400