Skip to content

fix(hook-decorator): upgrade django-lifecycle and remove type: ignore[misc] comments#7890

Open
afsuyadi wants to merge 2 commits into
Flagsmith:mainfrom
afsuyadi:fix/mypy-type-error
Open

fix(hook-decorator): upgrade django-lifecycle and remove type: ignore[misc] comments#7890
afsuyadi wants to merge 2 commits into
Flagsmith:mainfrom
afsuyadi:fix/mypy-type-error

Conversation

@afsuyadi

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • [✔] I have read the Contributing Guide.
  • [ ] I have added information to docs/ if required so people know about the feature.
  • [✔] I have filled in the "Changes" section below.
  • [✔] I have filled in the "How did you test this code" section below.

Changes

Contributes to #5240

  1. Upgraded django-lifecycle from 1.2.4 to 1.2.5 in pyproject.toml (both the version constraint and the pinned dev dependency)
  2. Removed 24 # type: ignore[misc] comments from @hook-decorated methods across 10 files

How did you test this code?

  1. Run make typecheck; pass with no [misc] errors
  2. Ran make test locally for those 10 files; 2041 tests passed, 0 failures.

Cli:
DJANGO_SETTINGS_MODULE=app.settings.test ./flagsmith/api/.venv/bin/pytest tests/unit/audit/ tests/unit/environments/ tests/unit/features/ tests/unit/projects/ tests/unit/users/ tests/unit/integrations/

Screenshot from 2026-06-26 19-36-24

@vercel

vercel Bot commented Jun 26, 2026

Copy link
Copy Markdown

@afsuyadi is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

@afsuyadi afsuyadi requested a review from a team as a code owner June 26, 2026 12:51
@afsuyadi afsuyadi requested review from emyller and removed request for a team June 26, 2026 12:51
@github-actions github-actions Bot added the api Issue related to the REST API label Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants