fix: return 404 for missing versioning parents#7880
Draft
Dexter2099 wants to merge 1 commit into
Draft
Conversation
|
@Dexter2099 is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Root cause
DRF runs permission checks before the feature-versioning view
initial()methods. These permission classes used directEnvironment.objects.get(...)/Feature.objects.get(...)lookups, so missing nested parents could raise rawDoesNotExistexceptions instead of returning a 404 response.Fixes #6556
Testing
uv run ruff check features/versioning/permissions.py tests/unit/features/versioning/test_unit_versioning_permissions.pyPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 DATABASE_URL=postgresql://postgres:password@localhost:5433/flagsmith ANALYTICS_DATABASE_URL=postgresql://postgres:password@localhost:5433/analytics uv run pytest -p django -p xdist.plugin -p pytest_mock tests/unit/features/versioning/test_unit_versioning_permissions.py -n0Note: I used the explicit pytest plugins above because local Windows plugin autoload hits a
pyreadlinecompatibility issue. The broader versioning view module also hits a Windows-onlygunicorn/fcntlimport path in this local environment.