Onboarding: e2e coverage, rename keeps tags, accessible names#7867
Closed
talissoncosta wants to merge 3 commits into
Closed
Onboarding: e2e coverage, rename keeps tags, accessible names#7867talissoncosta wants to merge 3 commits into
talissoncosta wants to merge 3 commits into
Conversation
Feature names are immutable, so the onboarding "rename" is a delete + recreate. The recreate started a bare flag, dropping the Onboarding tag attached in bootstrap (the badge vanished). Carry over the old flag's tags/type/description so the rename is non-lossy for what onboarding sets. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The two "Copy Code" buttons were indistinguishable to assistive tech, the flags table toggle had no accessible name, and the table wasn't a labelled region. Give the copy buttons distinct aria-labels, name the switch per flag, and label the flags region. Doubles as stable a11y-based handles for e2e (no test-ids). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
New-user happy path behind onboarding_quickstart_flow: sign up, land on the flow, copy the install/wire snippets (checklist ticks), toggle the Development flag, rename it (asserting the Onboarding tag survives the delete+recreate), and exercise the connected state via ?connected. Selectors are accessibility-first (roles / labels / text), not data-test ids. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
front-end
Contributor
Author
|
Folded into #7856 — the accessible names, the rename tag-preservation fix, and the e2e spec all landed there, so the stack is collapsed into one PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/if required so people know about the feature.Changes
Stacked on #7856. Follow-up from Wadii's review of the onboarding flow: e2e coverage plus a couple of robustness fixes.
onboarding_quickstart_flow: sign up, land on the flow, copy the install/wire snippets (checklist ticks), toggle the Development flag, rename it (asserting the tag survives), and the?connectedstate. Selectors are accessibility-first (roles / labels / text).How did you test this code?
Components type-check and lint clean. The e2e spec runs with
npm run test -- tests/onboarding-tests.pw.ts(withonboarding_quickstart_flowon); staying in draft until it has a green run.