fix(breadcrumb): align current-page item with links and separators#7401
fix(breadcrumb): align current-page item with links and separators#7401talissoncosta wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, reopen this pull request to trigger a review.
Docker builds report
|
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
|
Visual Regression16 screenshots compared. See report for details. |
The current-page div had `lh-sm` (line-height: small) while the link and separator items used the default h6 line-height, so the muted current page sat on a slightly different baseline than the rest of the trail. Drops `lh-sm` and replaces it with `mb-0` for consistency with the other items, so all three (link / separator / current) share the same baseline inside the flex row. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dd5a37a to
cbbe4ec
Compare
|
Tip All tests passed and all changes approved!🟢 UI Tests: 4 changes accepted as baselines |
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Follow-up to a review comment on #7100 (thread) — the breadcrumb's current-page item sat on a different baseline than the link/separator items, visible as the trailing label being slightly higher or lower than the rest of the trail.
How did you test this code?
Components/Navigation/Breadcrumb→ confirmed all three items (link /// current) sit on the same baseline.