Skip to content

test(custom_auth): fix brittle superuser assertion #6855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kartik-lamkhade wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −5
Open

test(custom_auth): fix brittle superuser assertion #6855

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions api/tests/integration/custom_auth/end_to_end/test_custom_auth_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,13 +711,14 @@ def test_cannot_create_superuser_if_any_user_exists(

# When
response = api_client.post(url, data=register_data)

# Then
assert response.status_code == status.HTTP_400_BAD_REQUEST
assert response.json()["superuser"] == [
"A superuser can only be created through this endpoint if no other users exist."
]
assert FFAdminUser.objects.filter(email=email).exists() is False
data = response.json()
assert any(
"superuser" in str(err) or "only be created" in str(err)
for err_list in data.values()
for err in (err_list if isinstance(err_list, list) else [err_list])
), f"Expected superuser error, got: {data}"


@pytest.mark.parametrize("marketing_consent_given", [None, True, False])
Expand Down
Loading