Skip to content

test: fix flaky tests #6848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthewelwell wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −10
Open

test: fix flaky tests #6848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d07e727
Fix flaky integration test that was reliant on non-deterministic orde…
matthewelwell Mar 4, 2026
646aef3
Fix flaky unit test that failed if the hashed percentage was 99
matthewelwell Mar 4, 2026
691b894
Use mvfo instead of value id
matthewelwell Mar 4, 2026
47c6c52
Remove logging
matthewelwell Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions api/tests/integration/environments/identities/test_integration_identities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def test_get_feature_states_for_identity( # type: ignore[no-untyped-def]
variant_1_percentage_allocation,
variant_1_value,
)
create_mv_option_with_api(
variant_2_mvfo_id = create_mv_option_with_api(
admin_client,
project,
multivariate_feature_id, # type: ignore[arg-type]
Expand Down Expand Up @@ -125,9 +125,11 @@ def test_get_feature_states_for_identity( # type: ignore[no-untyped-def]
feature_state_data = retrieve_feature_state_response.json()

# now let's amend the data so that all identities should receive variant 2
mv_values = feature_state_data["multivariate_feature_state_values"]
mv_values[0]["percentage_allocation"] = 0
mv_values[1]["percentage_allocation"] = 100
for mv_value in feature_state_data["multivariate_feature_state_values"]:
if mv_value["multivariate_feature_option"] == variant_2_mvfo_id:
mv_value["percentage_allocation"] = 100
else:
mv_value["percentage_allocation"] = 0

# and PUT the data back
update_feature_state_response = admin_client.put(
Expand Down
7 changes: 1 addition & 6 deletions api/tests/unit/environments/identities/test_unit_identities_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,14 +598,9 @@ def test_identities_endpoint_returns_value_for_segment_if_rule_type_percentage_s
segment=segment, type=SegmentRule.ALL_RULE
)

identity_percentage_value = get_hashed_percentage_for_object_ids(
[segment.id, identity.id]
)
Condition.objects.create(
operator=PERCENTAGE_SPLIT,
value=int(
(identity_percentage_value + (1 - identity_percentage_value) / 2) * 100.0
),
value=100,
rule=segment_rule,
)
feature_segment = FeatureSegment.objects.create(
Expand Down
Loading