Skip to content

fix: update-env-state-on-metadata-update #6831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zaimwa9 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −8
Open

fix: update-env-state-on-metadata-update #6831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions frontend/web/components/metadata/AddMetadataToEntity.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@ import { Metadata } from 'common/types/responses'
import Utils from 'common/utils/utils'
import Switch from 'components/Switch'
import InputGroup from 'components/base/forms/InputGroup'
import {
metadataService,
useGetEntityMetadataFieldsQuery,
} from 'common/services/useMetadataField'
import { getStore } from 'common/store'
import { useGetEntityMetadataFieldsQuery } from 'common/services/useMetadataField'
import { CustomMetadataField } from 'common/types/metadata-field'
import { useGlobalMetadataValidation } from 'common/utils/metadataValidation'
import RedirectCreateCustomFields from './RedirectCreateCustomFields'
Expand All @@ -26,6 +22,7 @@ type AddMetadataToEntityProps = {
entity: string
envName?: string
onChange?: (metadata: Metadata[]) => void
onMetadataSave?: (metadata: Metadata[]) => void
setHasMetadataRequired?: (b: boolean) => void
}

Expand Down Expand Up @@ -61,6 +58,7 @@ const AddMetadataToEntity: FC<AddMetadataToEntityProps> = ({
envName,
isCloningEnvironment,
onChange,
onMetadataSave,
organisationId,
projectId,
setHasMetadataRequired,
Expand Down Expand Up @@ -137,9 +135,7 @@ const AddMetadataToEntity: FC<AddMetadataToEntityProps> = ({
toast(errorMessage || 'Failed to update custom fields', 'danger')
} else {
toast('Environment Field Updated')
getStore().dispatch(
metadataService.util.invalidateTags([{ type: 'Metadata' }]),
)
onMetadataSave?.(formatMetadataToApi(metadataFields))
}
}

Expand Down
5 changes: 5 additions & 0 deletions frontend/web/components/pages/EnvironmentSettingsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,6 +920,11 @@ const EnvironmentSettingsPage: React.FC = () => {
envName={currentEnv?.name}
entityContentType={environmentContentType?.id}
entity={environmentContentType.model}
onMetadataSave={(metadata) => {
setCurrentEnv((prev) =>
prev ? { ...prev, metadata } : null,
)
}}
/>
}
/>
Expand Down
Loading