Conversation
Co-authored-by: Zaimwa9 <wadii.zaim@flagsmith.com>
# Conflicts: # frontend/web/components/pages/UserPage.tsx
# Conflicts: # frontend/common/providers/Permission.tsx # frontend/package-lock.json # frontend/package.json # frontend/web/components/feature-summary/FeatureRow.tsx # frontend/web/components/modals/FlagValueFooter.tsx # frontend/web/components/modals/create-feature/FeatureLimitAlert.tsx # frontend/web/components/modals/create-feature/index.js # frontend/web/components/modals/create-feature/tabs/CreateFeature.tsx # frontend/web/components/modals/create-feature/tabs/FeatureSettings.tsx # frontend/web/components/modals/create-feature/tabs/FeatureValue.tsx # frontend/web/components/mv/VariationOptions.tsx # frontend/web/components/navigation/navbars/ProjectNavbar.tsx # frontend/web/components/pages/FeaturesPage.js
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on March 10. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Free Tier Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Autofix Details
Bugbot Autofix prepared fixes for both issues found in the latest run.
- ✅ Fixed: Tooltip uses raw description instead of full permission message
- Updated the denied-permission tooltip to use
Constants.environmentPermissions(Utils.getManageFeaturePermission(is4Eyes))so the full message matches the actual permission being checked.
- Updated the denied-permission tooltip to use
- ✅ Fixed: Extra unused argument passed to getManageFeaturePermission
- Removed the unused
identityargument from all flagged calls togetManageFeaturePermissionandgetManageFeaturePermissionDescriptionto match their single-parameter signatures.
- Removed the unused
Or push these changes by commenting:
@cursor push 20ff32a0d6
Preview (20ff32a0d6)
diff --git a/frontend/web/components/modals/create-feature/index.js b/frontend/web/components/modals/create-feature/index.js
--- a/frontend/web/components/modals/create-feature/index.js
+++ b/frontend/web/components/modals/create-feature/index.js
@@ -49,9 +49,8 @@
import FeatureUpdateSummary from './FeatureUpdateSummary'
import FeatureNameInput from './FeatureNameInput'
import {
- EnvironmentPermission,
- EnvironmentPermissionDescriptions,
- ProjectPermission,
+ EnvironmentPermission,
+ ProjectPermission,
} from 'common/types/permissions.types'
const Index = class extends Component {
@@ -1149,7 +1148,6 @@
tags={projectFlag.tags}
permission={Utils.getManageFeaturePermission(
is4Eyes,
- identity,
)}
id={
this.props.environmentId
@@ -1205,7 +1203,6 @@
savePermission,
Utils.getManageFeaturePermissionDescription(
is4Eyes,
- identity,
),
<Button
onClick={() =>
@@ -1896,14 +1893,17 @@
tags={projectFlag.tags}
permission={Utils.getManageFeaturePermission(
is4Eyes,
- identity,
)}
id={this.props.environmentId}
>
{({ permission: savePermission }) =>
Utils.renderWithPermission(
savePermission,
- EnvironmentPermissionDescriptions.UPDATE_FEATURE_STATE,
+ Constants.environmentPermissions(
+ Utils.getManageFeaturePermission(
+ is4Eyes,
+ ),
+ ),
<div>
<Button
onClick={() => saveFeatureValue()}This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
|
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
|
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
|
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
|
talissoncosta
left a comment
talissoncosta
left a comment
There was a problem hiding this comment.
Thanks @kyle-ssg — this is a key step forward. Really appreciate it! 🙌
# Conflicts: # frontend/web/components/modals/create-feature/tabs/CreateFeature.tsx
5 participants
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
How did you test this code?
E2E, checking each usage of permission
Note: due to amount of refactoring I've done, I've pointed this to the latest branch I've been working on