feat!: declare MSRV 1.86 and enforce it in CI - #50
Merged
Conversation
The reqwest 0.13 bump (#49) raised the crate's effective MSRV: a fresh resolve pulls icu_* 2.2.0 and idna_adapter 1.2.2 (via url -> idna), which require rustc 1.86. Declare rust-version = "1.86.0" and add an MSRV workflow so future dependency bumps cannot silently invalidate it. BREAKING CHANGE: reqwest 0.13 changes the public API (reqwest::Error From impl, http 1.x HeaderMap), switches the default TLS backend from native-tls to rustls + aws-lc-rs, and requires rustc >= 1.86.
Zaimwa9
approved these changes
Aug 10, 2026
emyller
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to #49
Follow-up to the reqwest 0.13 bump, which raised the crate's effective MSRV: a fresh
cargoresolve pullsicu_*2.2.0 andidna_adapter1.2.2 (viaurl->idna), which require rustc 1.86. Building with 1.85.0 fails out of the box:This PR:
rust-version = "1.86.0"inCargo.tomlMSRVworkflow runningcargo +1.86.0 check, so future dependency bumps cannot silently invalidate the advertised MSRV (the existing Rust workflow only builds on latest stable)The
!in the PR title is intentional: the breaking commit from #49 (feat!(deps): ...) could not be parsed by release-please (the!must come after the scope:feat(deps)!:), so no release PR was created — see the workflow log:Squash-merging this PR with the title as-is lets release-please pick up the breaking change and cut 3.0.0, covering both the reqwest 0.13 bump and the new MSRV.
How did you test this code?
rustup toolchain install 1.86.0 --profile minimalandcargo +1.86.0 checkon this branch with a fresh resolve — passes (Finished dev profile)cargo +1.85.0 checkon a clean checkout of main — fails with therequires rustc 1.86error above, confirming 1.86 is the true floor