Skip to content

Conversation

@emyller
Copy link
Contributor

@emyller emyller commented Jan 15, 2026

Recurring tasks with a configured first run time could execute at the wrong time when evaluated near midnight UTC.

Changes

  • Recurring tasks now reliably respect their configured first run time regardless of when they are evaluated

Closes #62

Review effort: 1/5

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.70%. Comparing base (775362d) to head (5fdf9fb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
+ Coverage   95.67%   95.70%   +0.02%     
==========================================
  Files          85       85              
  Lines        2891     2908      +17     
==========================================
+ Hits         2766     2783      +17     
  Misses        125      125              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emyller emyller closed this Jan 15, 2026
@emyller emyller reopened this Jan 15, 2026
@emyller emyller changed the title fix(RecurringTask): Compare datetime objects in should_execute fix(Recurring Task): Prevent incorrect first run near midnight Jan 15, 2026
@emyller emyller force-pushed the fix/recurring-task-timezone-shadow branch from 1f2806f to ca391de Compare January 15, 2026 23:50
@emyller emyller force-pushed the fix/recurring-task-timezone-shadow branch from ca391de to 5fdf9fb Compare January 16, 2026 00:02
@emyller emyller self-assigned this Jan 16, 2026
@emyller emyller marked this pull request as ready for review January 16, 2026 00:06
@emyller emyller requested a review from a team as a code owner January 16, 2026 00:06
@emyller emyller requested review from khvn26 and removed request for a team January 16, 2026 00:06
@emyller emyller merged commit e07d3f3 into main Jan 16, 2026
3 checks passed
@emyller emyller deleted the fix/recurring-task-timezone-shadow branch January 16, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix recurring tasks not running within timezone shadow

4 participants