Skip to content

Fix Gemma reranker imports with Transformers v5 #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gui-Yue wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −2
Open

Fix Gemma reranker imports with Transformers v5 #1580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions FlagEmbedding/inference/reranker/decoder_only/models/gemma_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,13 @@
)
from .gemma_config import CostWiseGemmaConfig
from transformers.models.gemma2.modeling_gemma2 import Gemma2RMSNorm, Gemma2RotaryEmbedding, rotate_half, apply_rotary_pos_emb
from transformers.models.gemma2.modeling_gemma2 import Gemma2MLP, repeat_kv, Gemma2Attention, Gemma2DecoderLayer, GEMMA2_START_DOCSTRING
from transformers.models.gemma2.modeling_gemma2 import GEMMA2_INPUTS_DOCSTRING
from transformers.models.gemma2.modeling_gemma2 import Gemma2MLP, repeat_kv, Gemma2Attention, Gemma2DecoderLayer

try:
from transformers.models.gemma2.modeling_gemma2 import GEMMA2_START_DOCSTRING, GEMMA2_INPUTS_DOCSTRING
except ImportError:
GEMMA2_START_DOCSTRING = ""
GEMMA2_INPUTS_DOCSTRING = ""

if is_flash_attn_2_available():
from flash_attn import flash_attn_func, flash_attn_varlen_func
Expand Down
9 changes: 9 additions & 0 deletions tests/test_imports_v5.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,15 @@ def test_import_modeling_minicpm_reranker_inference():
assert LayerWiseMiniCPMForCausalLM is not None


def test_import_gemma_model_inference():
"""Test importing the Gemma reranker model module from inference."""
from FlagEmbedding.inference.reranker.decoder_only.models.gemma_model import (
CostWiseGemmaForCausalLM,
)

assert CostWiseGemmaForCausalLM is not None


def test_import_modeling_minicpm_reranker_finetune():
"""Test importing the modeling_minicpm_reranker module from finetune."""
from FlagEmbedding.finetune.reranker.decoder_only.layerwise.modeling_minicpm_reranker import (
Expand Down