Speed up CPU demeaning#81
Merged
Merged
Conversation
matthieugomez
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
=======================================
Coverage ? 54.46%
=======================================
Files ? 11
Lines ? 672
Branches ? 0
=======================================
Hits ? 366
Misses ? 306
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
matthieugomez
force-pushed
the
speedup-cpu-demeaning
branch
from
4e9166c to
dde77f7
Compare
matthieugomez
changed the title
Two CPU-side optimizations on top of FixedEffects#80, with no change to results. - FixedEffect: store group refs as Int32 when ngroups <= typemax(Int32), halving the dominant memory stream read by the scatter/gather kernels on every solver iteration. Every backend (CPU/GPU) and solve_coefficients! benefits; ngroups beyond Int32 keeps the original integer type. - lsmr!: replace LinearAlgebra.norm's overflow-safe (~8x slower) path with a SIMD sum-of-squares at the four hot norm call sites, accumulated in Float64 for accuracy. Restricted to concrete CPU Vector{Float32,Float64}; GPU arrays and FixedEffectCoefficients keep the generic norm. Bumps version to 3.3.0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
matthieugomez
force-pushed
the
speedup-cpu-demeaning
branch
from
dde77f7 to
a25c978
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speed up CPU demeaning with Int32 refs and faster 2-norm