Skip to content

chore(openspec): archive schema init force validation change - #1467

Merged
alfred-openspec merged 1 commit into
mainfrom
chore/archive-schema-init-force-validation
Jul 28, 2026
Merged

chore(openspec): archive schema init force validation change#1467
alfred-openspec merged 1 commit into
mainfrom
chore/archive-schema-init-force-validation

Conversation

@alfred-openspec

@alfred-openspec alfred-openspec commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Archives the completed OpenSpec change from #1446 and applies its schema-init requirement to the canonical spec.

Validation:

  • pnpm run build
  • pnpm exec openspec validate schema-init-command --type spec --strict
  • pnpm exec openspec validate fix-schema-init-force-validation-order --strict before archive

The existing patch changeset remains on main, and release PR #1380 already includes the data-loss fix in its patch notes.

Summary by CodeRabbit

  • Bug Fixes
    • schema init --force now validates all artifact IDs before replacing an existing schema.
    • If validation fails, the existing schema and its contents remain unchanged.
    • Successful forced initialization continues to replace the existing schema as expected.
    • Behavior is consistent across supported platforms, including Windows paths.
  • Tests
    • Added regression coverage for failed validation preservation and successful schema replacement.

@alfred-openspec
alfred-openspec requested a review from a team as a code owner July 28, 2026 00:22
@alfred-openspec
alfred-openspec requested review from clay-good and removed request for a team July 28, 2026 00:22
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 03f2e5e8-631f-42fe-9ecd-b3fdc0ddc9c3

📥 Commits

Reviewing files that changed from the base of the PR and between 6b3623a and f265df8.

📒 Files selected for processing (6)
  • openspec/changes/archive/2026-07-28-fix-schema-init-force-validation-order/.openspec.yaml
  • openspec/changes/archive/2026-07-28-fix-schema-init-force-validation-order/design.md
  • openspec/changes/archive/2026-07-28-fix-schema-init-force-validation-order/proposal.md
  • openspec/changes/archive/2026-07-28-fix-schema-init-force-validation-order/specs/schema-init-command/spec.md
  • openspec/changes/archive/2026-07-28-fix-schema-init-force-validation-order/tasks.md
  • openspec/specs/schema-init-command/spec.md

📝 Walkthrough

Walkthrough

Changes

Schema init validation ordering

Layer / File(s) Summary
Change design and verification plan
openspec/changes/archive/2026-07-28-fix-schema-init-force-validation-order/...
Documents validation before forced replacement, preservation on invalid artifacts, regression coverage, and verification tasks.
Schema init command requirements
openspec/changes/archive/2026-07-28-fix-schema-init-force-validation-order/specs/..., openspec/specs/schema-init-command/spec.md
Defines failure and success scenarios for artifact validation, schema preservation, replacement, and success reporting.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • Fission-AI/OpenSpec#525: Introduces the schema-management commands targeted by this schema initialization behavior specification.

Suggested reviewers: clay-good, tabishb

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: archiving the schema init force validation OpenSpec change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/archive-schema-init-force-validation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@alfred-openspec
alfred-openspec force-pushed the chore/archive-schema-init-force-validation branch from 0d6bb60 to f265df8 Compare July 28, 2026 00:23
@alfred-openspec
alfred-openspec added this pull request to the merge queue Jul 28, 2026
Merged via the queue into main with commit d32d49f Jul 28, 2026
16 checks passed
@alfred-openspec
alfred-openspec deleted the chore/archive-schema-init-force-validation branch July 28, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants