Fix Unity 6.5 SceneHandle and Object ID compile errors#1051
Open
Scrolen wants to merge 1 commit into
Open
Conversation
Adds a Unity compatibility helper for SceneHandle and UnityEngine.Object runtime IDs, replacing obsolete SceneHandle int conversions and Object.GetInstanceID usage that fail compilation in Unity 6.5. Also removes reliance on GetInstanceID sign checks when cleaning up runtime observer condition instances. Validated in Unity 6000.5.0f1 with zero compile errors, host/client connection, reconnect, global scene load/unload, and late client global scene synchronization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes Unity 6.5 compilation errors caused by obsolete Unity APIs that are now treated as compile-breaking errors.
Unity 6.5 reports direct
Object.GetInstanceID()usage as obsolete and recommendsGetEntityId(), and deprecates implicitSceneHandleconversions to/fromintin favor ofGetRawData()andFromRawData().Changes
UnityCompatibilityhelper methods for Unity-version-safe access to:UnityEngine.Objectruntime IDsSceneHandlevaluesSceneHandleconstruction from raw dataSceneHandleimplicitintconversions with raw handle access.GetInstanceID() < 0for observer condition cleanup and replaced it with explicit runtime-instance tracking.Validation
Tested in Unity
6000.5.0f1.Validation performed: