refact(location):refactor location implementation#129
Draft
Conversation
Signed-off-by: riteshkhadse <r.khadse@flick2know.com>
singhtaranjeet
requested changes
Mar 12, 2025
| '${Constants.locationNotAvailable}\n$defaultLocationReason', | ||
| } catch (e, s) { | ||
| logger.e(e, s); | ||
| final _location = await Geolocator.getLastKnownPosition().timeout( |
Contributor
There was a problem hiding this comment.
in case it took more then 5 seconds then it'll throw timeout exception.
…r _getLocation Signed-off-by: riteshkhadse <r.khadse@flick2know.com>
kapdroid
force-pushed
the
main
branch
5 times, most recently
from
74de0e6 to
f1ef088
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor location implementation in ui kit.
Breaking Changes:
LocationData->LocationModelgetAddressmethod will require latitude, longitude. (previously it was taking Position)Links :
No Link(s) added.
Commits
Tests
I added the following tests:
No Test(s) added.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).Breaking Change
Should be merge type: