Add @JsonWrapped annotation#346
Open
sri-adarsh-kumar wants to merge 2 commits into
Open
Conversation
cowtowncoder
left a comment
cowtowncoder
left a comment
Member
There was a problem hiding this comment.
Looks good, needs to add enabled property.
Not sure about usefulness of tests to be honest, but I guess they don't hurt.
Could probably just leave tests for applicability on all property accessors (Field, Method, (Constructor / Factory method) Parameter, Annotation (for annotation bundles)). Which simply needs Class definition(s) with annotation applied.
And I guess from that runtime retention checking makes sense.
Member
|
Marking as inclusion in |
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
- Add `boolean enabled() default true` to @JsonWrapped following the @JsonUnwrapped pattern, to allow mix-in annotations to disable wrapping - Add ElementType.ANNOTATION_TYPE to @target (matches @JsonUnwrapped) - Update Javadoc to document enabled=false as the canonical override idiom - Replace tests with structural/retention checks covering Field, Method, Constructor Parameter, and Annotation targets (per maintainer feedback) Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
sri-adarsh-kumar
force-pushed
the
feature/512-json-wrapped-annotation
branch
from
d263202 to
d761882
Compare
Author
|
@cowtowncoder Would you be able to approve the build step here so jackson-databind can detect the new annotation for it's build? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
@JsonWrappedto jackson-annotations as part of the work done in FasterXML/jackson-databind#5715Actual serialization/deserialization support remains in jackson-databind.