feat(cli): warn on torch/onnxruntime version mismatch in export cache#219
Open
mvanhorn wants to merge 1 commit into
Open
feat(cli): warn on torch/onnxruntime version mismatch in export cache#219mvanhorn wants to merge 1 commit into
mvanhorn wants to merge 1 commit into
Conversation
… on mismatch Stores build-time torch and onnxruntime versions in cache metadata and warns at load when they differ from the current environment, so a stale/incompatible cached export isn't reused silently. Closes FastCrest#47 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Export caches were reused even when the torch / onnxruntime versions had changed, which can silently produce a stale or incompatible cached artifact (#47). The CLI now records the build-time torch and ORT versions in the cache metadata and warns on a mismatch at load.
Changes
cli.py: capture currenttorch.__version__/onnxruntime.__version__(falling back to"unknown"when unavailable) and store them in the cache metadata; on load, compare against the cached values and emit a clear mismatch warning.Testing
PYTHONPATH=src python3 -m pytest tests/test_cli.py— 15 passed, including version-match (no warning) and version-mismatch (warns) cases.Closes #47
AI was used for assistance.