feat(runtime): move record writing to a background worker thread#218
Open
mvanhorn wants to merge 1 commit into
Open
feat(runtime): move record writing to a background worker thread#218mvanhorn wants to merge 1 commit into
mvanhorn wants to merge 1 commit into
Conversation
Public writes enqueue to a bounded in-process queue drained by a daemon worker thread, so disk latency no longer stalls callers. The worker flushes per record, so a crash loses at most one record. Closes FastCrest#48 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves record writing off the request path (#48). Public writes now enqueue to a bounded in-process queue drained by a daemon worker thread, so a slow or blocked disk no longer stalls the caller. The worker flushes per record, so a writer crash loses at most one record.
Changes
runtime/record.py: boundedqueue.Queue(RECORD_QUEUE_MAXSIZE), a background worker thread, and a sentinel-based clean shutdown; image redaction preserved.runtime/server.py: wired to the queue-backed writer.Testing
PYTHONPATH=src python3 -m pytest tests/test_record.py— 36 passed (enqueue/flush, shutdown drains the queue, redaction modes, bounded-queue behavior).Closes #48
AI was used for assistance.