Open
Conversation
Should fix Fast-Trips#187 in a hacky way.
that needs to be os.path
addressing issue with python 2.x and sphinx
…s_python2 � Conflicts: � tests/test_weight_qualifiers.py
Fixes tests to deal with behavior changes in Python and to get around…
…on method for now
Deprecates python2
…uplication by combining assignment and skimming path finding exposed c++ method
…e interpreter is possible
Janzill/skimming with current setup
Cleans workflows
readme update
Member
|
Hi @janzill and @pedrocamargo - |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lmz here it is finally! If you want to see it in action have a look at the tests or run the Springfield example script I've added.
There is some background in the docs, mainly at https://janzill.github.io/fast-trips/howitworks.html#skimming and https://janzill.github.io/fast-trips/io.html#skim-classes-ft-file (this was generated and deployed automatically with the github actions workflows Pedro added). The bottom line is that we use one-to-all pathfinding instead of re-using the zone-to-zone path building of the assignment to improve runtimes, and we parallelise over origins.
As discussed, python2 is deprecated and tests are only run for python3.7 onwards. There's a bit of pandas code that requires pandas>=1.2 and therefore python3.6 (for which security support is ending in a month) is not supported, if that is a deal breaker let me know and I can change it.
Let me know what you think!