Add handling for incorrect entity lookdirs#1025
Open
Robotgiggle wants to merge 1 commit intoFallingColors:mainfrom
Open
Add handling for incorrect entity lookdirs#1025Robotgiggle wants to merge 1 commit intoFallingColors:mainfrom
Robotgiggle wants to merge 1 commit intoFallingColors:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vanilla code has sign errors in the look direction vectors returned by projectiles and phantoms. This PR adds special handling in OpEntityLook to account for that.
I realize that a system like the one currently used for special velocity getters might be better in concept, but since this bug applies to literally all projectiles regardless of individual entity type, I figured it would be simpler to just do what I've done here.