Add log download modal#968
Merged
1Blademaster merged 4 commits intomainfrom Feb 2, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds functionality to download flight logs directly from the drone through a new modal interface in the Flight Log Analyzer. It removes state-based access restrictions for FTP operations, adds intelligent log file discovery, and enhances the file reading functionality to save files directly to disk.
Changes:
- Added new
listLogFilesendpoint that intelligently searches for logs in common directories (/logs, /APM/LOGS, etc.) - Modified
readFileto optionally save files directly to disk instead of returning data over the socket - Removed state-based restrictions that previously required users to be on the config screen to access FTP operations
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| radio/tests/test_ftp.py | Removed state validation tests and added basic test for listLogFiles endpoint |
| radio/app/endpoints/ftp.py | Removed state checks, added listLogFiles endpoint, modified readFile to support save_path parameter |
| radio/app/controllers/ftpController.py | Added listLogFiles method with intelligent directory detection, enhanced readFile to save to disk |
| gcs/src/redux/slices/ftpSlice.js | Added logPath state, modified file addition logic for direct directory listings, exported cancelReadFile action |
| gcs/src/redux/middleware/socketMiddleware.js | Added handler for list_log_files_result event |
| gcs/src/redux/middleware/emitters.js | Added emitter for list_log_files, updated read_file emitter to include savePath |
| gcs/src/components/fla/SelectFlightLog.jsx | Added button to open download modal when connected to drone |
| gcs/src/components/fla/DownloadLogModal.jsx | New modal component for browsing and downloading log files from drone |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1Blademaster
deleted the
908-add-ability-to-download-logs-for-analysis
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.