Skip to content

Add file progress bar and fix some additional bugs#946

Merged
1Blademaster merged 2 commits into
mainfrom
919-display-file-download-progress-bar
Jan 14, 2026
Merged

Add file progress bar and fix some additional bugs#946
1Blademaster merged 2 commits into
mainfrom
919-display-file-download-progress-bar

Conversation

@1Blademaster
Copy link
Copy Markdown
Member

image

Copilot AI review requested due to automatic review settings January 7, 2026 20:24
@1Blademaster 1Blademaster linked an issue Jan 7, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a file download progress bar to the FTP functionality and fixes timeout handling for long-running operations. The progress bar provides real-time feedback showing bytes downloaded, total bytes, and percentage complete during file transfers.

  • Added progress callback mechanism for file downloads with real-time updates via WebSocket
  • Fixed timeout logic to reset on each response rather than using absolute timeout from operation start
  • Implemented conditional timeout handling for directory listings based on path content

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
radio/app/endpoints/ftp.py Adds progress_callback to emit real-time download progress via WebSocket
radio/app/controllers/ftpController.py Implements progress callback in readFile, fixes timeout logic to reset on each response, adds path-based timeout configuration for listFiles
gcs/src/redux/slices/ftpSlice.js Adds readFileProgress state and associated actions/selectors to track download progress
gcs/src/redux/middleware/socketMiddleware.js Handles read_file_progress socket events and manages progress state cleanup on completion/error
gcs/src/redux/middleware/emitters.js Resets progress state when initiating new file downloads
gcs/src/components/config/ftp.jsx Displays progress bar UI with download statistics during file transfers

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread radio/app/controllers/ftpController.py
Comment thread gcs/src/redux/middleware/socketMiddleware.js
Comment thread gcs/src/redux/middleware/socketMiddleware.js
Comment thread radio/app/controllers/ftpController.py
@1Blademaster 1Blademaster requested a review from a team January 7, 2026 20:53
Copy link
Copy Markdown
Contributor

@Kwash67 Kwash67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@1Blademaster 1Blademaster merged commit fe87788 into main Jan 14, 2026
8 of 9 checks passed
@1Blademaster 1Blademaster deleted the 919-display-file-download-progress-bar branch January 14, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display file download progress bar

3 participants