Add file progress bar and fix some additional bugs#946
Merged
Conversation
Member
1Blademaster
commented
Jan 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a file download progress bar to the FTP functionality and fixes timeout handling for long-running operations. The progress bar provides real-time feedback showing bytes downloaded, total bytes, and percentage complete during file transfers.
- Added progress callback mechanism for file downloads with real-time updates via WebSocket
- Fixed timeout logic to reset on each response rather than using absolute timeout from operation start
- Implemented conditional timeout handling for directory listings based on path content
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| radio/app/endpoints/ftp.py | Adds progress_callback to emit real-time download progress via WebSocket |
| radio/app/controllers/ftpController.py | Implements progress callback in readFile, fixes timeout logic to reset on each response, adds path-based timeout configuration for listFiles |
| gcs/src/redux/slices/ftpSlice.js | Adds readFileProgress state and associated actions/selectors to track download progress |
| gcs/src/redux/middleware/socketMiddleware.js | Handles read_file_progress socket events and manages progress state cleanup on completion/error |
| gcs/src/redux/middleware/emitters.js | Resets progress state when initiating new file downloads |
| gcs/src/components/config/ftp.jsx | Displays progress bar UI with download statistics during file transfers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.