Only allow one FTP operation at a time#941
Merged
1Blademaster merged 3 commits intomainfrom Dec 31, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a locking mechanism to prevent concurrent FTP operations by introducing a current_op field that tracks the currently executing operation. The implementation uses try-finally blocks to ensure the lock is always released, even when errors occur.
Key Changes:
- Added
current_opinstance variable to track active FTP operations - Wrapped
listFilesandreadFilemethods with try-finally blocks for automatic cleanup - Added comprehensive test coverage for blocking behavior and cleanup scenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| radio/app/controllers/ftpController.py | Implements operation locking mechanism with current_op tracking and try-finally cleanup in listFiles and readFile methods |
| radio/tests/test_ftpController.py | Adds test coverage for concurrent operation blocking, error cleanup, and sequential operation execution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.