907 add ability to download files#921
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds the ability to download files from the drone's FTP server. The implementation includes backend support for reading files via MAVFTP protocol, frontend state management for file operations, and a UI component for displaying and downloading file contents.
Key changes:
- Backend implementation of file reading using MAVFTP burst read and gap-filling operations
- Redux state management for tracking file read operations and storing file bytes
- UI enhancements to display file content preview and provide download functionality
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| radio/app/endpoints/ftp.py | Added readFile endpoint to handle file read requests from clients |
| radio/app/controllers/ftpController.py | Implemented MAVFTP file reading with burst read, gap detection, and gap-filling logic |
| gcs/src/redux/slices/ftpSlice.js | Added state management for file reading operations and file bytes storage |
| gcs/src/redux/middleware/socketMiddleware.js | Added socket event handling for file read results |
| gcs/src/redux/middleware/emitters.js | Added emitter for triggering file read operations |
| gcs/src/components/config/ftp.jsx | Enhanced UI with file content preview and download button |
| .vscode/settings.json | Updated mypy configuration (unrelated to main feature) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
NexInfinite
left a comment
NexInfinite
left a comment
There was a problem hiding this comment.
Works for me locally, code looks good but it is a large diff so I may have missed some things.
Tested on linux
No description provided.