905 add ability to list files and directories#909
Merged
1Blademaster merged 11 commits intomainfrom Dec 14, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements FTP file listing capabilities for drone file systems via MAVLink FTP protocol. The implementation adds a complete client-server architecture with backend FTP controller, WebSocket endpoints, Redux state management, and a React-based file browser UI.
- Introduces
FtpControllerclass to handle MAVLink FTP protocol operations including session management and directory listing - Adds WebSocket endpoint for listing files with state validation and error handling
- Creates Redux slice for FTP state management with hierarchical file tree structure
- Implements Tree-based UI component in config page to display and navigate drone filesystem
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
radio/app/controllers/ftpController.py |
New controller implementing MAVLink FTP operations with session management, command sending, response parsing, and directory entry conversion |
radio/app/endpoints/ftp.py |
WebSocket endpoint for list_files operation with state and connection validation |
radio/app/endpoints/__init__.py |
Registers the FTP endpoint module |
radio/app/drone.py |
Integrates FtpController into drone initialization sequence |
radio/tests/test_ftpController.py |
Unit tests for the directory entry conversion helper method |
radio/requirements.txt |
Updates pymavlink from 2.4.40 to 2.4.49 to support FTP operations |
gcs/src/redux/store.js |
Adds ftpSlice to Redux store and reorganizes imports alphabetically |
gcs/src/redux/slices/ftpSlice.js |
Redux slice managing FTP state with file tree structure and directory listing actions |
gcs/src/redux/middleware/socketMiddleware.js |
Adds socket listener for list_files_result events |
gcs/src/redux/middleware/emitters.js |
Adds emitter for list_files socket events |
gcs/src/config.jsx |
Adds FTP tab to config page and imports FTP component |
gcs/src/components/config/ftp.jsx |
React component rendering file tree with lazy-loading of subdirectories |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.