Add tests for exporting params to file#889
Merged
1Blademaster merged 3 commits intomainfrom Nov 28, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive test coverage for the export params to file functionality. The tests verify proper error handling for various edge cases and successful file export with content validation.
- Tests for wrong application state, missing file path, incorrect file path, and successful export
- New fixtures for cleaning up exported files and injecting test parameters
- Test data file containing 1384 parameter entries in .parm format
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| radio/tests/test_params.py | Adds PARAM_FILES_PATH constant, two test fixtures (delete_export_files and inject_params), and four test functions covering various scenarios for param export functionality |
| radio/tests/param_test_files/inject_params.parm | Provides test data with 1384 parameter entries used for validating successful export operations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Kwash67
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.