Add sensor calibration timeout for test setup#879
Merged
1Blademaster merged 3 commits intomainfrom Nov 28, 2025
Merged
Conversation
1Blademaster
force-pushed
the
878-tests-with-simulator-get-stuck-calibrating-occasionally
branch
from
220eacb to
45fff0d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a timeout mechanism for the sensor calibration process during test setup to prevent tests from hanging indefinitely if the drone fails to calibrate. Previously, waitUntilCalibrated() would block indefinitely; now it times out after 5 seconds and gracefully exits the test session.
Key changes:
- Added a 5-second timeout to the
waitUntilCalibrated()function with proper error logging - Changed
waitUntilCalibrated()to return a boolean indicating success/failure - Added calibration success validation in
pytest_sessionstart()to exit tests if calibration fails
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Will re-check when #881 get's merged in |
Kwash67
approved these changes
Nov 28, 2025
1Blademaster
deleted the
878-tests-with-simulator-get-stuck-calibrating-occasionally
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.