Update states tests, reset message listeners on state change#870
Merged
1Blademaster merged 1 commit intomainfrom Nov 25, 2025
Merged
Update states tests, reset message listeners on state change#8701Blademaster merged 1 commit intomainfrom
1Blademaster merged 1 commit intomainfrom
Conversation
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the state tests and adds a new method to clear message listeners when changing drone states. The primary change is introducing clearAllMessageListeners() to properly reset message listeners during state transitions, ensuring clean state management.
Key changes:
- Split monolithic
test_setStateinto separate focused test functions - Added
clearAllMessageListeners()method to the Drone class - Integrated listener cleanup into the
set_stateendpoint to prevent listener accumulation
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| radio/tests/test_states.py | Refactored single test function into 5 separate test functions, each testing a specific state scenario with descriptive names and docstrings |
| radio/app/endpoints/states.py | Added call to clearAllMessageListeners() to reset message listeners when changing states |
| radio/app/drone.py | Added clearAllMessageListeners() method and refactored close() to use it instead of manual iteration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.