847 show feedback when writing multiple params

[1Blademaster]

[1Blademaster]

I think it'd be nice in another issue to show a scrollable list of all the feedback messages within the modal.

[1Blademaster]

I also would like to add a cross to close the modal or a button to close the modal, this will also act as a "cancel" action

[Copilot]

Pull Request Overview

This PR adds progress tracking and better error handling for setting multiple parameters on a drone. Users can now see real-time progress while parameters are being written, and receive detailed feedback about which parameters succeeded or failed.

Key changes:

• Added progress callback mechanism to report parameter write status in real-time
• Improved error handling to continue processing remaining parameters even if some fail
• Modified UI to show progress modal during writes and failure modal for unsuccessful parameters

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
radio/app/endpoints/params.py	Added progress callback type definition and function, updated set_multiple_params to pass callback
radio/app/controllers/paramsController.py	Enhanced setMultipleParams with progress callback support and better error handling; refactored setParam to return saved_param status and reduce timeout
gcs/src/redux/slices/paramsSlice.js	Added state management for write progress tracking and failed parameter handling
gcs/src/redux/middleware/socketMiddleware.js	Added handling for progress updates and differentiated success/warning/error notifications based on results
gcs/src/redux/middleware/emitters.js	Triggered progress modal when emitting set_multiple_params
gcs/src/params.jsx	Added two new modal components for displaying write progress and failures
gcs/src/helpers/notification.js	Added warning notification support with yellow color
gcs/src/components/params/valueInput.jsx	Fixed appendModifiedParams call to pass array instead of object
gcs/src/components/params/paramsWriteModal.jsx	New component showing progress bar while writing parameters
gcs/src/components/params/paramsFailedToWriteModal.jsx	New component showing table of parameters that failed to write

Comments suppressed due to low confidence (2)

radio/app/controllers/paramsController.py:187

• The docstring is missing documentation for the progress_update_callback parameter that was added to the function signature.

            params_list (list[IncomingParam]): The list of parameters to set

radio/app/controllers/paramsController.py:190

• The return type documentation is outdated. The function now returns a Response dictionary, not a boolean.

            bool: True if all parameters were set, False if any failed

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Kwash67]

LGTM