Enable GLOBAL_POSITION_INT message to be streamed at all times#846
Merged
1Blademaster merged 2 commits intomainfrom Nov 10, 2025
Merged
Enable GLOBAL_POSITION_INT message to be streamed at all times#8461Blademaster merged 2 commits intomainfrom
1Blademaster merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the state management in the drone telemetry system by extracting message listener configurations into module-level constants and optimizing the control flow, while also removing telemetry socket error logging from the frontend.
- Refactored message listener configurations from inline dictionaries to module-level constants (
GLOBAL_MESSAGE_LISTENERSandSTATES_MESSAGE_LISTENERS) - Consolidated data stream initialization with a global setup that applies to all states, replacing per-state duplicate setups
- Removed telemetry socket connection error handler from the frontend middleware
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| radio/app/endpoints/states.py | Refactored state-based telemetry configuration by extracting listener configurations to module-level constants and introducing global message listeners that apply to all states |
| gcs/src/redux/middleware/socketMiddleware.js | Removed the connect_error event handler for the telemetry socket |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1Blademaster
deleted the
829-gps-track-not-logged-when-not-on-dashboard
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.