Skip to content

774 add mavlink forwarding#777

Merged
1Blademaster merged 10 commits intomainfrom
774-add-mavlink-forwarding
Oct 26, 2025
Merged

774 add mavlink forwarding#777
1Blademaster merged 10 commits intomainfrom
774-add-mavlink-forwarding

Conversation

@1Blademaster
Copy link
Copy Markdown
Member

@1Blademaster 1Blademaster commented Oct 24, 2025

image image image

@1Blademaster 1Blademaster linked an issue Oct 24, 2025 that may be closed by this pull request
@1Blademaster 1Blademaster requested a review from Copilot October 25, 2025 09:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds MAVLink message forwarding functionality, allowing the GCS to forward incoming MAVLink packets to another address (e.g., another GCS or application) in a one-way manner. The feature includes UI controls for configuring forwarding addresses, starting/stopping forwarding, and automatic forwarding initialization on connection.

Key changes:

  • Backend support for forwarding MAVLink messages to configurable UDP/TCP addresses
  • New "Advanced" toolbar menu with MAVLink forwarding option
  • Redux state management for forwarding address and status
  • Modal UI for configuring and controlling message forwarding

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
radio/app/endpoints/connections.py Added socket endpoints for starting and stopping MAVLink forwarding
radio/app/endpoints/comPorts.py Added forwarding_address parameter handling in drone connection flow
radio/app/endpoints/autopilot.py Added TODO comment for forwarding address handling during autopilot reboot
radio/app/drone.py Implemented core forwarding logic including address validation, connection management, and message forwarding in checkForMessages
gcs/src/redux/store.js Added localStorage persistence for forwarding address and status
gcs/src/redux/slices/droneConnectionSlice.js Added Redux state, actions, and selectors for forwarding feature
gcs/src/redux/middleware/socketMiddleware.js Added socket listener for forwarding status updates
gcs/src/redux/middleware/emitters.js Implemented emitters for start/stop forwarding actions
gcs/src/components/toolbar/toolbar.jsx Integrated new Advanced menu into toolbar
gcs/src/components/toolbar/menus/view.jsx Moved Connection Stats menu item to Advanced menu
gcs/src/components/toolbar/menus/advanced.jsx Created new Advanced menu with Connection Stats and MAVLink Forwarding options
gcs/src/components/navbar.jsx Added forwarding configuration modal and forwarding status notification in connection modal

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread radio/app/endpoints/comPorts.py Outdated
Comment thread radio/app/drone.py Outdated
Comment thread gcs/src/redux/middleware/emitters.js
Comment thread gcs/src/components/navbar.jsx
@1Blademaster
Copy link
Copy Markdown
Member Author

1Blademaster commented Oct 26, 2025

Need to update mac menu bar once #789 is merged. - Will do in a different ticket actually.

@1Blademaster 1Blademaster requested a review from a team October 26, 2025 12:13
Copy link
Copy Markdown
Contributor

@NexInfinite NexInfinite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1Blademaster 1Blademaster merged commit fd0a3db into main Oct 26, 2025
8 checks passed
@1Blademaster 1Blademaster deleted the 774-add-mavlink-forwarding branch October 26, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add mavlink forwarding

3 participants