Fix pre-release bugs found#732
Merged
1Blademaster merged 3 commits intorelease-alpha-0.1.10from Sep 28, 2025
Merged
Conversation
Fix com ports not saving to local storage Add progress bar text to params page Add button to fetch params if failed Fixed radio calibration page hiding if no rc data Fix dashboard mission loading notification not being hidden Try forcing mavlink 2 Fix params controller thread not ending Fix backend crashing if aircraft is using mavlink1 Fix get all params thread timing out too soon
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes multiple pre-release bugs to improve application stability and user experience. The changes address connection issues, parameter handling improvements, and UI/UX enhancements.
- Fix com ports not saving to local storage and improve connection handling
- Enhance parameters page with progress indicators and retry functionality
- Improve thread management and timeout handling for parameter operations
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| radio/tests/test_params.py | Skip flaky test with TODO comment |
| radio/app/endpoints/states.py | Add state change logging |
| radio/app/endpoints/params.py | Increase timeout and add current param ID tracking |
| radio/app/drone.py | Improve params controller thread cleanup |
| radio/app/controllers/paramsController.py | Enhanced parameter fetching with better timeouts and state management |
| radio/app/controllers/missionController.py | Improve error messages for mavlink compatibility |
| radio/app/controllers/gripperController.py | Change gripper warning to info level |
| radio/app.py | Force mavlink 2 protocol |
| gcs/src/redux/store.js | Add com port persistence to local storage |
| gcs/src/redux/slices/paramsSlice.js | Update progress tracking to include param ID |
| gcs/src/redux/slices/missionSlice.js | Add mission notification cleanup function |
| gcs/src/redux/middleware/socketMiddleware.js | Improve RC channel handling and connection error logging |
| gcs/src/params.jsx | Add progress text and retry button for parameter fetching |
| gcs/src/components/spotlight/commandHandler.js | Improve error logging and import organization |
| gcs/src/components/navbar.jsx | Handle invalid com port selection |
| gcs/src/components/dashboard/preFlightChecklist/checkListArea.jsx | Remove debug console log and organize imports |
| gcs/src/components/config/radioCalibration.jsx | Reorganize imports |
| gcs/package.json | Version bump to 0.2.0-alpha |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
NexInfinite
approved these changes
Sep 28, 2025
1Blademaster
added a commit
that referenced
this pull request
Sep 28, 2025
* Fix pre-release bugs found Fix com ports not saving to local storage Add progress bar text to params page Add button to fetch params if failed Fixed radio calibration page hiding if no rc data Fix dashboard mission loading notification not being hidden Try forcing mavlink 2 Fix params controller thread not ending Fix backend crashing if aircraft is using mavlink1 Fix get all params thread timing out too soon * Address copilot review comments * Try fix clock not updating
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.